Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1537 split services 1 #361

Merged
merged 12 commits into from
Aug 25, 2023
Merged

1537 split services 1 #361

merged 12 commits into from
Aug 25, 2023

Conversation

nutrina
Copy link
Collaborator

@nutrina nutrina commented Aug 23, 2023

@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 21:28 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 21:28 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 22:13 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 22:13 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 22:22 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 22:22 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 22:31 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 22:31 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 24, 2023 22:37 — with GitHub Actions Inactive
@nutrina
Copy link
Collaborator Author

nutrina commented Aug 25, 2023

The aws.rds.Instance instances in prod should be protected.
The one for redash is missing the protected flag.
You can add this as the 3rd argument (see the other instances):

  { protect: true }

Also, we might want to protect all instance in staging as well, I don't see any reason not do do this.

@nutrina
Copy link
Collaborator Author

nutrina commented Aug 25, 2023

Also we might drop the "scorer-run-createsuperuser" task as we do not use that.

@tim-schultz tim-schultz temporarily deployed to Staging August 25, 2023 16:00 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 25, 2023 16:00 — with GitHub Actions Inactive
@tim-schultz tim-schultz temporarily deployed to Staging August 25, 2023 16:06 — with GitHub Actions Inactive
@tim-schultz tim-schultz merged commit 1504cc3 into main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Scorer Service into Distinct Service Groups
2 participants